Fix fallback finding of ccd #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix finding include directory for ccd when falling back from using pkg-config. The old mechanism would find the include directory as e.g. `prefix/include/ccd`, which fails when we try to include `ccd/ccd.h`. Drop the path suffix and instead search for the literal name `ccd/ccd.h`, which will produce the correct include path.
|
This looks fine to me, although I didn't test it. Anyone object to merging it? |
|
I was just about to create an issue and supply a PR for this exact same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix finding include directory for ccd when falling back from using pkg-config. The old mechanism would find the include directory as e.g.
prefix/include/ccd, which fails when we try to includeccd/ccd.h. Drop the path suffix and instead search for the literal nameccd/ccd.h, which will produce the correct include path.